Fix deprecation warnings thrown when used with PHP 8.4 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some warnings reported when used with PHP 8.4, due to the deprecation of implicit nullability for typed method arguments.
Motivation and context
PHP 8.4 now warns when doing things like
GeneratorInterface $generator = nullinstead of explicitly marking the argument as nullable:?GeneratorInterface $generator = null.In PHP 9 this will throw an error.
How has this been tested?
I checked the execution of PHPUnit does not print any warning when run in PHP 8.4
Screenshots (if appropriate)
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Technically speaking, this is a bug fix, although, the approach used to solve the warning (mark arguments as nullable), requires to bump the minimum supported PHP version to 7.1
An alternative approach would be to remove the native type from arguments entirely, and rely on types defined in PHPDocs. That would allow to keep compatibility with all versions. I'm ok going in that direction if preferred.