Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/lift coverage to 70 #827

Merged
merged 10 commits into from
Nov 14, 2023
Merged

Chore/lift coverage to 70 #827

merged 10 commits into from
Nov 14, 2023

Conversation

NicolaMirchev
Copy link
Contributor

Description:

Added more unit tests in different files

This PR modifies couple of test files in order get the coverage higher

Added tests for:

  • account_info.go
  • assessed_custom_fee.go
  • contract_create_flow.go
  • system_delete_transaction.go
  • system_undelete_transaction.go

Related issue(s):
(#703 (comment))

NikolaMirchev added 8 commits November 7, 2023 13:24
Signed-off-by: NikolaMirchev <[email protected]>
Added new test and fixed a bug in _fromProtobuf() func

Signed-off-by: NikolaMirchev <[email protected]>
…system_undelete_transaction.go'

Signed-off-by: NikolaMirchev <[email protected]>
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (e97ed41) 69.75% compared to head (6049d8d) 70.69%.
Report is 3 commits behind head on develop.

❗ Current head 6049d8d differs from pull request most recent head dfad911. Consider uploading reports for the commit dfad911 to get more accurate results

Files Patch % Lines
account_id.go 76.31% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #827      +/-   ##
===========================================
+ Coverage    69.75%   70.69%   +0.93%     
===========================================
  Files          164      164              
  Lines        34094    34126      +32     
===========================================
+ Hits         23782    24124     +342     
+ Misses        8943     8610     -333     
- Partials      1369     1392      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Petyo-Lukanov Petyo-Lukanov linked an issue Nov 7, 2023 that may be closed by this pull request
@NicolaMirchev NicolaMirchev requested a review from rokn November 8, 2023 13:08
NikolaMirchev added 2 commits November 14, 2023 14:17
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@NicolaMirchev NicolaMirchev merged commit ba7027e into develop Nov 14, 2023
@NicolaMirchev NicolaMirchev deleted the chore/lift-coverage-to-70 branch November 14, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get test coverage to 70%
2 participants