825 invalid fallback mirror node insecure port #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 8, 2023 10:12
Signed-off-by: NikolaMirchev <[email protected]>
Signed-off-by: NikolaMirchev <[email protected]>
Signed-off-by: NikolaMirchev <[email protected]>
rokn
approved these changes
Nov 9, 2023
client_unit_test.go
Outdated
| @@ -96,6 +97,7 @@ func TestUnitClientFromConfigWrongNetworkType(t *testing.T) { | |||
|
|
|||
| func TestUnitClientFromConfigWrongAccountIDNetworkType(t *testing.T) { | |||
| _, err := ClientFromConfig([]byte(testClientJSONWrongAccountIDNetwork)) | |||
| fmt.Println(err) | |||
There was a problem hiding this comment.
nit: i don't think we need this
Signed-off-by: NikolaMirchev <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
NicolaMirchev
deleted the
825-invalid-fallback-mirror-node-insecure-port
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
_toInsecurefunction of the mirror nodes.hcs.testnet.mirrornode.hedera.comto the actual onetestnet.mirrornode.hedera.comRelated issue(s):
#825
Fixes #
Removed port 5600 from
_toInsecurefunction of the mirror nodes.Note:
_toInsecure()function called for mirror node will remain on secured port 443Notes for reviewer:
Checklist