Changes request #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hifeful
reviewed
Jun 24, 2023
| * 🟡 Please, answer on them before moving further and after changes would be made | ||
| * 1️⃣ How the configuration changes are handled with Feature (if so)? | ||
| * 2️⃣ Can we have MVI using ViewModel or Presenter? | ||
| * 3️⃣ Could the race conditions issue happen |
There was a problem hiding this comment.
- I'm using the MVICore library to implement MVI in the application. This library has a Timecapsule that can help to save/restore configuration changes. But I didn't implement it. More info -> https://badoo.github.io/MVICore/features/timecapsule/
- We can wrap our Feature in the ViewModel or Presenter if we really need it.
- I don't think so, because MVI is implemented using Observer pattern. All user actions are passed to the Observable flow and handled individually. And also State in MVI is immutable, so we copy and create new objects, we don't change existing variables in the State object.
hifeful
reviewed
Jun 24, 2023
| * > the domain layer shouldn't have any dependencies, even to another domain | ||
| * > the data layer should have only the dedicated domain dependency, and no another data layers | ||
| * > of course, there might be exception, but usually we should avoid it | ||
| */ |
There was a problem hiding this comment.
Agree. I knew that but decided to not duplicate classes for such a simple application. Of course in the multi-modular architecture, it's mandatory.
|
Things are going to be improved within #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @hifeful