Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit-tests #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

unit-tests #3

wants to merge 2 commits into from

Conversation

hifeful
Copy link
Owner

@hifeful hifeful commented Aug 19, 2023

  • unit tests for a MealManiaViewModel, MealDetailsViewState, and Reducer of the MealDetailsFeature were added

epam-alyse
epam-alyse reviewed Aug 21, 2023
View reviewed changes
Copy link

@epam-alyse epam-alyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT are the task requirements exactly the way of TDD?

app/src/test/java/com/hifeful/mealmania/presentation/MealManiaViewModelTest.kt Outdated Show resolved Hide resolved
app/src/test/java/com/hifeful/mealmania/presentation/MealManiaViewModelTest.kt Outdated Show resolved Hide resolved
app/src/test/java/com/hifeful/mealmania/presentation/MealManiaViewModelTest.kt Outdated Show resolved Hide resolved
app/src/test/java/com/hifeful/mealmania/presentation/MealManiaViewModelTest.kt Outdated Show resolved Hide resolved
app/src/test/java/com/hifeful/mealmania/presentation/details/MealDetailsViewStateTest.kt Outdated Show resolved Hide resolved
epam-alyse
epam-alyse suggested changes Aug 21, 2023
View reviewed changes
Copy link

@epam-alyse epam-alyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to demonstrate usage of Robolectric

@hifeful
- AssertJ and mockK libraries were added and used for the unit tests
26004ba 
- mocks instead of real objects are used in the MealDetailsViewStateTest now
- test titles in the MealManiaViewModelTest.kt were changed
- comments were removed
@hifeful
Copy link
Owner Author

hifeful commented Aug 21, 2023

WDYT are the task requirements exactly the way of TDD?

If we're talking about the strict TDD, then we should start writing our code from the unit tests.
So, we should write tests that don't compile regarding our business logic and then implement the actual code.
Unfortunately, I didn't work on projects like that and I'm not quite sure if it's really needed.

@hifeful
Copy link
Owner Author

hifeful commented Aug 21, 2023

Needs to demonstrate usage of Robolectric

Regarding the usage of Robolectic, in my unit tests, I added @RunWith annotation with the AndroidJUnit4 runner that makes available classes from the Android SDK. I needed Uri and Context classes, so Robolectric helped me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epam-alyse epam-alyse epam-alyse requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hifeful @epam-alyse