Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSCSCI-1545 ibc cases not autolisted #4310

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

SSCSCI-1545 ibc cases not autolisted #4310

wants to merge 9 commits into from

Conversation

erclaudio
Copy link

@erclaudio erclaudio commented Jan 16, 2025 •
edited
Loading

See https://tools.hmcts.net/jira/browse/SSCSCI-1545

Change description

Testing done

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@erclaudio erclaudio requested a review from a team as a code owner January 16, 2025 11:31
@github-actions GitHub Actions
Copy link

CCD diff report

No change

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

Integration Tests results

   82 files  ±0     82 suites  ±0   9m 4s ⏱️ -7s
1 425 tests ±0  1 417 ✅ ±0  8 💤 ±0  0 ❌ ±0 
1 426 runs  ±0  1 418 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 439f92a. ± Comparison against base commit 5a932cf.

This pull request removes 9 and adds 9 tests. Note that renamed tests count towards both. 
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED) [7]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED_WELSH) [5]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_GRANTED) [1]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_REFUSED) [9]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO) [2]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO_WELSH) [4]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SET_ASIDE_GRANTED) [0]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SOR_EXTEND_TIME) [6]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SOR_REFUSED) [3]

uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED) [2]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED_WELSH) [3]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_GRANTED) [9]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_REFUSED) [6]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO) [1]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO_WELSH) [0]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SET_ASIDE_GRANTED) [4]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SOR_EXTEND_TIME) [7]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SOR_REFUSED) [5]

♻️ This comment has been updated with latest results.

@nilay913 nilay913 changed the title ibc cases not autolisted + test SSCSCI-1545 ibc cases not autolisted Jan 17, 2025
@github-actions GitHub Actions
Copy link

CCD diff report

No change

erclaudio added 2 commits January 17, 2025 17:38
ibc cases not autolisted
141a44e 
autolisted if ibc case and overridden to yes
not autolisted if ibc case and overridden to no
Merge remote-tracking branch 'origin/SSCSCI-1545' into SSCSCI-1545
5142924
@github-actions GitHub Actions
Copy link

CCD diff report

No change

@github-actions GitHub Actions
Copy link

CCD diff report

No change

linusnorton
linusnorton reviewed Jan 20, 2025
View reviewed changes
src/main/java/uk/gov/hmcts/reform/sscs/helper/mapping/HearingsAutoListMapping.java Outdated
@@ -39,6 +35,18 @@ public static boolean shouldBeAutoListed(@Valid SscsCaseData caseData, Reference
return isYes(overrideFields.getAutoList());
}

if (Objects.equals(caseData.getBenefitCode(), "022")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think you can do this in a single if statement:

if ("022".equals(caseData.getBenefitCode() ||"067".equals(...) || caseData.isIbcCase()) {
  return false;
}

But also, are those strings "022" / "067" available as enums anywhere?

@github-actions GitHub Actions
Copy link

CCD diff report

No change

@github-actions GitHub Actions
Copy link

CCD diff report

No change

@erclaudio erclaudio requested a review from linusnorton January 21, 2025 14:16
@github-actions GitHub Actions
Copy link

CCD diff report

No change

@github-actions GitHub Actions
Copy link

CCD diff report

No change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linusnorton linusnorton Awaiting requested review from linusnorton

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ns:sscs prd:sscs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erclaudio @linusnorton @nilay913