SSCSCI-1588 #4323

nilay913 · 2025-01-22T15:01:53Z

Jira link

See SSCSCI-1588

Change description

Pointing to new templates to replace hardcoded "NI No" with <> placeholder for draft and final decision notice

Testing done

Checklist

commit messages are meaningful and follow good commit message guidelines
README and other documentation has been updated / added (if needed)
tests have been updated / new tests has been added (if needed)
Does this PR introduce a breaking change

github-actions · 2025-01-22T15:02:28Z

CCD diff report

No change

github-actions · 2025-01-22T15:03:18Z

CCD diff report

No change

github-actions · 2025-01-22T15:14:48Z

Integration Tests results

80 files ±0 80 suites ±0 12m 46s ⏱️ -45s
1 423 tests ±0 1 415 ✅ ±0 8 💤 ±0 0 ❌ ±0
1 424 runs ±0 1 416 ✅ ±0 8 💤 ±0 0 ❌ ±0

Results for commit 21e8822. ± Comparison against base commit 2a38b5e.

This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both.

uk.gov.hmcts.reform.sscs.config.DocumentConfigurationTest ‑ testDocumnetConfig(ENGLISH, CORRECTION_GRANTED, Optional.empty, TB-SCS-GNO-ENG-corrected-decision-notice.docx) [0]
uk.gov.hmcts.reform.sscs.config.DocumentConfigurationTest ‑ testDocumnetConfig(ENGLISH, DECISION_ISSUED, Optional.empty, TB-SCS-GNO-ENG-draft-decision-notice.docx) [1]
uk.gov.hmcts.reform.sscs.config.DocumentConfigurationTest ‑ testDocumnetConfig(ENGLISH, DIRECTION_ISSUED, Optional.empty, TB-SCS-GNO-ENG-directions-notice.docx) [2]
uk.gov.hmcts.reform.sscs.config.DocumentConfigurationTest ‑ testDocumnetConfig(ENGLISH, ISSUE_FINAL_DECISION, Optional.empty, TB-SCS-GNO-ENG-final-decision-notice.docx) [3]
uk.gov.hmcts.reform.sscs.config.DocumentConfigurationTest ‑ testDocumnetConfig(WELSH, CORRECTION_GRANTED, Optional.empty, TB-SCS-GNO-ENG-corrected-decision-notice.docx) [4]
uk.gov.hmcts.reform.sscs.config.DocumentConfigurationTest ‑ testDocumnetConfig(WELSH, DECISION_ISSUED, Optional.empty, TB-SCS-GNO-WEL-00473.docx) [5]
uk.gov.hmcts.reform.sscs.config.DocumentConfigurationTest ‑ testDocumnetConfig(WELSH, DIRECTION_ISSUED, Optional.empty, TB-SCS-GNO-WEL-00473.docx) [6]
uk.gov.hmcts.reform.sscs.config.DocumentConfigurationTest ‑ testDocumnetConfig(WELSH, ISSUE_FINAL_DECISION, Optional.empty, TB-SCS-GNO-ENG-final-decision-notice.docx) [7]

uk.gov.hmcts.reform.sscs.config.DocumentConfigurationTest ‑ testDocumentConfig(ENGLISH, CORRECTION_GRANTED, Optional.empty, TB-SCS-GNO-ENG-corrected-decision-notice.docx) [0]
uk.gov.hmcts.reform.sscs.config.DocumentConfigurationTest ‑ testDocumentConfig(ENGLISH, DECISION_ISSUED, Optional.empty, TB-SCS-GNO-ENG-draft-decision-notice-v2.docx) [1]
uk.gov.hmcts.reform.sscs.config.DocumentConfigurationTest ‑ testDocumentConfig(ENGLISH, DIRECTION_ISSUED, Optional.empty, TB-SCS-GNO-ENG-directions-notice.docx) [2]
uk.gov.hmcts.reform.sscs.config.DocumentConfigurationTest ‑ testDocumentConfig(ENGLISH, ISSUE_FINAL_DECISION, Optional.empty, TB-SCS-GNO-ENG-final-decision-notice-v2.docx) [3]
uk.gov.hmcts.reform.sscs.config.DocumentConfigurationTest ‑ testDocumentConfig(WELSH, CORRECTION_GRANTED, Optional.empty, TB-SCS-GNO-ENG-corrected-decision-notice.docx) [4]
uk.gov.hmcts.reform.sscs.config.DocumentConfigurationTest ‑ testDocumentConfig(WELSH, DECISION_ISSUED, Optional.empty, TB-SCS-GNO-ENG-draft-decision-notice-v2.docx) [5]
uk.gov.hmcts.reform.sscs.config.DocumentConfigurationTest ‑ testDocumentConfig(WELSH, DIRECTION_ISSUED, Optional.empty, TB-SCS-GNO-ENG-directions-notice.docx) [6]
uk.gov.hmcts.reform.sscs.config.DocumentConfigurationTest ‑ testDocumentConfig(WELSH, ISSUE_FINAL_DECISION, Optional.empty, TB-SCS-GNO-ENG-final-decision-notice-v2.docx) [7]

♻️ This comment has been updated with latest results.

github-actions · 2025-01-22T15:20:46Z

CCD diff report

No change

benouaer · 2025-01-22T15:55:04Z

src/IntegrationTests/java/uk/gov/hmcts/reform/sscs/config/DocumentConfigurationTest.java

@@ -39,13 +39,13 @@ public class DocumentConfigurationTest {
    public static Object[][] documentParameters() {
        return new Object[][] {
                {LanguagePreference.ENGLISH, EventType.CORRECTION_GRANTED, Optional.empty(), "TB-SCS-GNO-ENG-corrected-decision-notice.docx"},


should we get these from the yaml as well?

maybe a task as part of clean up too?

benouaer · 2025-01-22T15:55:41Z

src/main/resources/config/application.properties.old

@@ -71,13 +71,13 @@ docmosis.uri=${DOCMOSIS_SERVICE_BASE_URL:https://docmosis.aat.platform.hmcts.net
 documents.english.CORRECTION_GRANTED=TB-SCS-GNO-ENG-corrected-decision-notice.docx


is this file still being used?

unsure, updated it just in case

benouaer · 2025-01-22T16:03:34Z

general question not necessarily about your changes:

do we really need all those yaml files? surely we can use the main one, and only create a separate one when we need to override some properties
do we need to specify the name of the template in all those places? should we not just get it from the yaml?

nilay913 · 2025-01-22T16:06:23Z

general question not necessarily about your changes:

do we really need all those yaml files? surely we can use the main one, and only create a separate one when we need to override some properties

do we need to specify the name of the template in all those places? should we not just get it from the yaml?

I don't think they're really needed, maybe as part of a clean up ticket we can remove some seemingly redundant ones? i.e. application.properties.old

github-actions · 2025-01-22T16:17:19Z

CCD diff report

No change

github-actions · 2025-01-22T16:56:23Z

CCD diff report

No change

pointing to new templates

01bd5bf

nilay913 requested a review from a team as a code owner January 22, 2025 15:01

nilay913 added the enable_keep_helm label Jan 22, 2025

Merge branch 'master' into SSCSCI-1588

0d28618

hmcts-jenkins-j-to-z bot deployed to preview January 22, 2025 15:11 View deployment

hmcts-jenkins-j-to-z bot added ns:sscs prd:sscs labels Jan 22, 2025

nilay913 added 2 commits January 22, 2025 15:19

updating tests and properties

c8bc98d

Merge remote-tracking branch 'origin/SSCSCI-1588' into SSCSCI-1588

24d1bf3

hmcts-jenkins-j-to-z bot deployed to preview January 22, 2025 15:28 View deployment

benouaer reviewed Jan 22, 2025

View reviewed changes

benouaer approved these changes Jan 22, 2025

View reviewed changes

test fix

81355bc

hmcts-jenkins-j-to-z bot deployed to preview January 22, 2025 16:27 View deployment

Merge branch 'master' into SSCSCI-1588

21e8822

hmcts-jenkins-j-to-z bot deployed to preview January 22, 2025 17:04 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SSCSCI-1588 #4323

SSCSCI-1588 #4323

nilay913 commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

github-actions bot commented Jan 22, 2025 •

edited

Loading

github-actions bot commented Jan 22, 2025

benouaer Jan 22, 2025

nilay913 Jan 22, 2025

benouaer Jan 22, 2025

nilay913 Jan 22, 2025

benouaer commented Jan 22, 2025

nilay913 commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

		@@ -71,13 +71,13 @@ docmosis.uri=${DOCMOSIS_SERVICE_BASE_URL:https://docmosis.aat.platform.hmcts.net
		documents.english.CORRECTION_GRANTED=TB-SCS-GNO-ENG-corrected-decision-notice.docx

SSCSCI-1588 #4323

Are you sure you want to change the base?

SSCSCI-1588 #4323

Conversation

nilay913 commented Jan 22, 2025

Jira link

Change description

Testing done

Checklist

github-actions bot commented Jan 22, 2025

CCD diff report

github-actions bot commented Jan 22, 2025

CCD diff report

github-actions bot commented Jan 22, 2025 • edited Loading

Integration Tests results

github-actions bot commented Jan 22, 2025

CCD diff report

benouaer Jan 22, 2025

Choose a reason for hiding this comment

nilay913 Jan 22, 2025

Choose a reason for hiding this comment

benouaer Jan 22, 2025

Choose a reason for hiding this comment

nilay913 Jan 22, 2025

Choose a reason for hiding this comment

benouaer commented Jan 22, 2025

nilay913 commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

CCD diff report

github-actions bot commented Jan 22, 2025

CCD diff report

github-actions bot commented Jan 22, 2025 •

edited

Loading