Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSCSCI-1560 #4329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SSCSCI-1560 #4329

wants to merge 1 commit into from

Conversation

hashimalisolirius
Copy link
Contributor

Jira link

https://tools.hmcts.net/jira/browse/SSCSCI-1560

Change description

Return null for language interpreter instead of throwing exception

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@hashimalisolirius hashimalisolirius requested a review from a team as a code owner January 24, 2025 09:47
Copy link

CCD diff report

No change

Copy link

Integration Tests results

   80 files  ±0     80 suites  ±0   13m 5s ⏱️ -7s
1 423 tests ±0  1 415 ✅ ±0  8 💤 ±0  0 ❌ ±0 
1 424 runs  ±0  1 416 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit f65f0b0. ± Comparison against base commit 4338941.

This pull request removes 15 and adds 15 tests. Note that renamed tests count towards both.
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED) [0]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED_WELSH) [4]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_GRANTED) [1]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_REFUSED) [5]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO) [8]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO_WELSH) [3]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SET_ASIDE_GRANTED) [9]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SET_ASIDE_REFUSED) [6]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SOR_EXTEND_TIME) [7]
uk.gov.hmcts.reform.sscs.tyanotifications.tya.NotificationItForReviewConfidentialityRequestTest ‑ givenAppellantConfidentialityRequest_shouldSendConfidentialityLetter(DatedRequestOutcome[requestOutcome=granted, date=2025-01-23]) [0]
…
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED) [4]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(DIRECTION_ISSUED_WELSH) [8]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_GRANTED) [0]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(LIBERTY_TO_APPLY_REFUSED) [3]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO) [7]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(PROCESS_AUDIO_VIDEO_WELSH) [9]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SET_ASIDE_GRANTED) [5]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SET_ASIDE_REFUSED) [1]
uk.gov.hmcts.reform.sscs.tyanotifications.config.BundledNotificationsConfigTestIt ‑ given_bundledLetters_should_notHaveTemplate(SOR_EXTEND_TIME) [6]
uk.gov.hmcts.reform.sscs.tyanotifications.tya.NotificationItForReviewConfidentialityRequestTest ‑ givenAppellantConfidentialityRequest_shouldSendConfidentialityLetter(DatedRequestOutcome[requestOutcome=granted, date=2025-01-24]) [0]
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant