-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate sample_rate #268
Conversation
@cbrnr @cfranklin11 @LucaCerina @raphaelvallat @DimitriPapadopoulos if any of you has time to have a look, that would be great :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Good also for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor suggestions, otherwise LGTM (although I didn't check the record duration calculation since I don't have the time at the moment).
Found something strange: Even though the f.setDatarecordDuration(0.123456)
...
AssertionError: read 0.12345 != expected 0.123456 In the raw header there is an empty space this issue might be related #242. I suggest fixing this in a future PR. |
Given that the the requested changes were minor, I'll merge this one :) thanks for reviewing! |
As discussed in #247 , I deprecated
sample_rate
and replaced all of its occurences withsample_frequency
.Frequency is usually measured in Hz, which is defined per second and is most consistent with other libraries (e.g.
mne
).Summary
sample_rate
- this is to ensure everyone finds out about the change without googelingrecord_duration
- it should find an optimal value if one exists and let users not worry about thesample_rate
as it is defined inedflib
but to simply seysample_frequency
and be donerecord_duration
if ppl actually need to for obscure reasonsAdditionally, needed to deprecate 3.7 for the test suite as it's not available for ubuntu24
fixes #198
closes #247