Novel idea: actually implement close method to tidy up classloaders t…

…o try and avoid memory leaks
holly-cummins · Jan 21, 2025 · 632914f · 632914f
1 parent a9ef435
commit 632914f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/core/deployment/src/main/java/io/quarkus/test/junit/classloading/FacadeClassLoader.java b/core/deployment/src/main/java/io/quarkus/test/junit/classloading/FacadeClassLoader.java
@@ -686,8 +686,9 @@ public String getName() {
 
     @Override
     public void close() {
-        // TODO clearly, an implementation is needed!
-
+        for (CuratedApplication curatedApplication : curatedApplications.values()) {
+            curatedApplication.close();
+        }
     }
 
     public void setProfiles(Map<String, String> profiles) {

diff --git a/.../junit5/src/main/java/io/quarkus/test/junit/util/QuarkusTestProfileAwareClassOrderer.java b/.../junit5/src/main/java/io/quarkus/test/junit/util/QuarkusTestProfileAwareClassOrderer.java
@@ -106,7 +106,6 @@ public QuarkusTestProfileAwareClassOrderer() {
 
     @Override
     public void orderClasses(ClassOrdererContext context) {
-        System.out.println("HOLLY YUP YUP ordering classes");
         // don't do anything if there is just one test class or the current order request is for @Nested tests
         if (context.getClassDescriptors()
                 .size() <= 1 || context.getClassDescriptors()