Test classoading rewrite - CI run

.forbiddenapis/banned-signatures-common.txt

@@ -6,3 +6,13 @@ org.jboss.jandex.AnnotationValue#toString()
 @defaultMessage Replace this by using InputStream.transferTo(OutputStream)
 org.apache.commons.io.IOUtils#copy(java.io.InputStream,java.io.OutputStream)
 org.apache.commons.compress.utils.IOUtils#copy(java.io.InputStream,java.io.OutputStream)
+
+@defaultMessage We should avoid using WildFly Common APIs
+org.wildfly.common.Assert
+org.wildfly.common.net.**
+org.wildfly.common.os.**
+
+@defaultMessage Use JUnit asserts
+io.smallrye.common.Assert.assertTrue(**)
+io.smallrye.common.Assert.assertFalse(**)
+io.smallrye.common.Assert.assertNotNull(**)

.github/dependabot.yml

@@ -36,6 +36,7 @@ updates:
       - dependency-name: com.google.cloud.tools:jib-core
       - dependency-name: org.jboss.threads:jboss-threads
       - dependency-name: org.jboss.marshalling:*
+      - dependency-name: org.wildfly.common:*
       # Quarkus
       - dependency-name: io.quarkus.*:*
       - dependency-name: io.quarkus:*

.github/matrix-jvm-tests.json

@@ -1,20 +1,46 @@
-[ {
-  "name": "17",
+[
+    {
+        "name": "JVM Tests - JDK 17",
+  "java-version": 17,
+  "maven_args": "$JVM_TEST_MAVEN_ARGS",
+  "maven_opts": "-Xmx2g -XX:MaxMetaspaceSize=1g",
+    "os-name": "ubuntu-22.04"
+    },
+    {
+        "name": "JVM Tests - JDK 21",
+  "java-version": 21,
+  "java-version-gradle": 20,
+  "maven_args": "$JVM_TEST_MAVEN_ARGS",
+  "maven_opts": "-Xmx3g -XX:MaxMetaspaceSize=1g",
+        "os-name": "ubuntu-latest"
+    },
+    {
+        "name": "JVM Tests - JDK 17 Windows",
+        "java-version": 17,
+        "maven_args": "-DskipDocs -Dformat.skip",
+        "maven_opts": "-Xmx2g -XX:MaxMetaspaceSize=1g",
+        "os-name": "windows-latest"
+    },
+    {
+        "name": "JVM Integration Tests - JDK 17",
+        "category": "Integration",
   "java-version": 17,
   "maven_args": "$JVM_TEST_MAVEN_ARGS",
   "maven_opts": "-Xmx2g -XX:MaxMetaspaceSize=1g",
   "os-name": "ubuntu-latest"
-}
-, {
-  "name": "21",
+    },
+    {
+        "name": "JVM Integration Tests - JDK 21",
+        "category": "Integration",
   "java-version": 21,
   "java-version-gradle": 20,
   "maven_args": "$JVM_TEST_MAVEN_ARGS",
   "maven_opts": "-Xmx3g -XX:MaxMetaspaceSize=1g",
   "os-name": "ubuntu-latest"
-}
-, {
-  "name": "17 Windows",
+    },
+    {
+        "name": "JVM Integration Tests - JDK 17 Windows",
+        "category": "Integration",
   "java-version": 17,
   "maven_args": "-DskipDocs -Dformat.skip",
   "maven_opts": "-Xmx2g -XX:MaxMetaspaceSize=1g",

.github/native-tests.json

@@ -22,13 +22,13 @@
             "category": "Data3",
             "timeout": 75,
             "test-modules": "flyway, hibernate-orm-panache, hibernate-orm-panache-kotlin, hibernate-orm-envers, liquibase, liquibase-mongodb",
-            "os-name": "ubuntu-latest"
+      "os-name": "ubuntu-latest"
         },
         {
             "category": "Data4",
             "timeout": 60,
             "test-modules": "mongodb-client, mongodb-devservices, mongodb-panache, mongodb-rest-data-panache, mongodb-panache-kotlin, redis-client, hibernate-orm-rest-data-panache",
-            "os-name": "ubuntu-latest"
+      "os-name": "ubuntu-latest"
         },
         {
             "category": "Data5",
@@ -44,8 +44,14 @@
         },
         {
             "category": "Data7",
-            "timeout": 85,
-            "test-modules": "reactive-oracle-client, reactive-mysql-client, reactive-db2-client, hibernate-reactive-db2, hibernate-reactive-mariadb, hibernate-reactive-mysql, hibernate-reactive-mysql-agroal-flyway, hibernate-reactive-panache, hibernate-reactive-panache-kotlin",
+            "timeout": 90,
+            "test-modules": "reactive-oracle-client, reactive-mysql-client, reactive-db2-client, hibernate-reactive-db2, hibernate-reactive-mariadb, hibernate-reactive-mssql, hibernate-reactive-mysql, hibernate-reactive-mysql-agroal-flyway, hibernate-reactive-panache, hibernate-reactive-panache-kotlin",
+            "os-name": "ubuntu-latest"
+        },
+        {
+            "category": "Build tools and DevTools",
+            "timeout": 75,
+            "test-modules": "maven, gradle, devtools-registry-client",
             "os-name": "ubuntu-latest"
         },
         {
@@ -76,48 +82,48 @@
             "category": "Security2",
             "timeout": 75,
             "test-modules": "oidc, oidc-code-flow, oidc-tenancy, oidc-client, oidc-client-reactive, oidc-token-propagation, oidc-wiremock, oidc-client-wiremock, oidc-wiremock-providers, oidc-dev-services",
-            "os-name": "ubuntu-latest"
-        },
-        {
-            "category": "Security3",
-            "timeout": 55,
-            "test-modules": "keycloak-authorization, smallrye-jwt-token-propagation, security-webauthn",
-            "os-name": "ubuntu-latest"
-        },
-        {
-            "category": "Cache",
-            "timeout": 75,
-            "test-modules": "infinispan-cache-jpa, infinispan-client, cache, redis-cache, infinispan-cache",
-            "os-name": "ubuntu-latest"
-        },
-        {
-            "category": "HTTP",
-            "timeout": 130,
-            "test-modules": "elytron-resteasy, resteasy-jackson, elytron-resteasy-reactive, resteasy-mutiny, resteasy-reactive-kotlin/standard, vertx, vertx-http, vertx-web, vertx-http-compressors/all, vertx-http-compressors/some, vertx-web-jackson, vertx-graphql, virtual-http, rest-client, rest-client-reactive, rest-client-reactive-stork, rest-client-reactive-multipart, websockets, websockets-next, management-interface, management-interface-auth, mutiny-native-jctools",
-            "os-name": "ubuntu-latest"
-        },
-        {
-            "category": "Misc1",
-            "timeout": 70,
-            "test-modules": "maven, jackson, jsonb, kotlin, rest-client-reactive-kotlin-serialization, quartz, qute, logging-min-level-unset, logging-min-level-set, simple with space",
+      "os-name": "ubuntu-latest"
+    },
+    {
+      "category": "Security3",
+      "timeout": 55,
+      "test-modules": "keycloak-authorization, smallrye-jwt-token-propagation, security-webauthn",
+      "os-name": "ubuntu-latest"
+    },
+    {
+      "category": "Cache",
+      "timeout": 75,
+      "test-modules": "infinispan-cache-jpa, infinispan-client, cache, redis-cache, infinispan-cache",
+      "os-name": "ubuntu-latest"
+    },
+    {
+      "category": "HTTP",
+      "timeout": 130,
+      "test-modules": "elytron-resteasy, resteasy-jackson, elytron-resteasy-reactive, resteasy-mutiny, resteasy-reactive-kotlin/standard, vertx, vertx-http, vertx-web, vertx-http-compressors/all, vertx-http-compressors/some, vertx-web-jackson, vertx-graphql, virtual-http, rest-client, rest-client-reactive, rest-client-reactive-stork, rest-client-reactive-multipart, websockets, websockets-next, management-interface, management-interface-auth, mutiny-native-jctools",
+      "os-name": "ubuntu-latest"
+    },
+    {
+      "category": "Misc1",
+      "timeout": 70,
+            "test-modules": "jackson, jsonb, kotlin, rest-client-reactive-kotlin-serialization, quartz, qute, logging-min-level-unset, logging-min-level-set, simple with space, web-dependency-locator",
             "os-name": "ubuntu-latest"
         },
         {
             "category": "Misc2",
             "timeout": 75,
-            "test-modules": "hibernate-validator, test-extension/tests, logging-gelf, mailer, native-config-profile, locales/all, locales/some, locales/default",
+            "test-modules": "hibernate-validator, test-extension/tests, logging-gelf, mailer, native-config-profile, locales/all, locales/some, locales/default, jaxp, jaxb",
             "os-name": "ubuntu-latest"
         },
         {
             "category": "Misc3",
             "timeout": 80,
-            "test-modules": "kubernetes-client, openshift-client, kubernetes-service-binding-jdbc, smallrye-config, smallrye-graphql, smallrye-graphql-client, smallrye-graphql-client-keycloak, smallrye-metrics",
+            "test-modules": "kubernetes-client, openshift-client, kubernetes-service-binding-jdbc, smallrye-config, smallrye-graphql, smallrye-graphql-client, smallrye-graphql-client-keycloak,  picocli-native",
             "os-name": "ubuntu-latest"
         },
         {
-            "category": "Misc4",
+            "category": "Observability",
             "timeout": 130,
-            "test-modules": "picocli-native, gradle, micrometer-mp-metrics, micrometer-prometheus, logging-json, jaxp, jaxb, observability-lgtm, opentelemetry, opentelemetry-jdbc-instrumentation, opentelemetry-mongodb-client-instrumentation, opentelemetry-redis-instrumentation, web-dependency-locator",
+            "test-modules": "smallrye-metrics, micrometer-mp-metrics, micrometer-prometheus, logging-json, observability-lgtm, opentelemetry, opentelemetry-jdbc-instrumentation, opentelemetry-mongodb-client-instrumentation, opentelemetry-redis-instrumentation, micrometer-opentelemetry",
             "os-name": "ubuntu-latest"
         },
         {
@@ -138,12 +144,6 @@
             "test-modules": "resteasy-jackson, qute, liquibase",
             "os-name": "windows-latest"
         },
-        {
-            "category": "DevTools Integration Tests",
-            "timeout": 75,
-            "test-modules": "devtools-registry-client",
-            "os-name": "ubuntu-latest"
-        },
         {
             "category": "AWT, ImageIO and Java2D, Packaging .so files",
             "timeout": 40,

.github/quarkus-github-bot.yml

@@ -37,6 +37,11 @@ projects:
 triage:
   discussions:
     monitoredCategories: [33575230]
+  guardedBranches:
+    - ref: 3.15
+      notify: [jmartisk, gsmet, gastaldi, rsvoboda, aloubyansky]
+    - ref: 3.8
+      notify: [jmartisk, gsmet, gastaldi, rsvoboda, aloubyansky]
   rules:
     - id: amazon-lambda
       labels: [area/amazon-lambda]
@@ -470,7 +475,7 @@ triage:
       notify: [radcortez]
     - id: core
       labels: [area/core]
-      notify: [aloubyansky, gsmet, geoand, radcortez, Sanne, stuartwdouglas]
+      notify: [aloubyansky, gsmet, geoand, radcortez, Sanne]
       directories:
         - core/
     - id: dependencies
@@ -624,7 +629,7 @@ triage:
     - id: rest
       labels: [area/rest]
       title: resteasy.reactive
-      notify: [geoand, FroMage, stuartwdouglas]
+      notify: [geoand, FroMage]
       directories:
         - extensions/resteasy-reactive/
     - id: scala
@@ -719,11 +724,11 @@ triage:
     - id: continuous-testing
       labels: [area/continuous-testing]
       title: "continuous.testing"
-      notify: [stuartwdouglas]
+      notify: [holly-cummins, geoand]
     - id: devservices
       labels: [area/devservices]
       title: "dev.?services?"
-      notify: [stuartwdouglas, geoand]
+      notify: [geoand]
     - id: jdbc
       labels: [area/jdbc]
       title: "jdbc"

.github/quarkus-github-lottery.yml

@@ -29,6 +29,23 @@ buckets:
     timeout: P14D
     ignoreLabels: ["triage/on-ice"]
 participants:
+  - username: "DavideD"
+    timezone: "Europe/Vienna"
+    triage:
+      days: ["MONDAY", "TUESDAY", "WEDNESDAY", "THURSDAY", "FRIDAY"]
+      maxIssues: 3
+    maintenance:
+      labels: ["area/hibernate-orm", "area/hibernate-reactive", "area/hibernate-validator", "area/hibernate-search", "area/jdbc"]
+      days: ["WEDNESDAY", "THURSDAY", "FRIDAY"] # Count me out on Monday and Tuesday.
+      created:
+        maxIssues: 3
+      feedback:
+        needed:
+          maxIssues: 3
+        provided:
+          maxIssues: 3
+      stale:
+        maxIssues: 1
   - username: "yrodiere"
     timezone: "Europe/Paris"
     triage:

.github/workflows/ci-actions-incremental.yml

@@ -53,7 +53,11 @@ env:
   COMMON_MAVEN_ARGS: "-e -B --settings .github/mvn-settings.xml --fail-at-end"
   COMMON_TEST_MAVEN_ARGS: "-Dformat.skip -Denforcer.skip -DskipDocs -Dforbiddenapis.skip -DskipExtensionValidation -DskipCodestartValidation"
   NATIVE_TEST_MAVEN_ARGS: "-Dtest-containers -Dstart-containers -Dquarkus.native.native-image-xmx=6g -Dnative -Dnative.surefire.skip -Dno-descriptor-tests clean install -DskipDocs"
-  JVM_TEST_MAVEN_ARGS: "-Dtest-containers -Dstart-containers -Dquarkus.test.hang-detection-timeout=60"
+  JVM_TEST_MAVEN_ARGS: "-Dtest-containers -Dstart-containers -Dquarkus.test.hang-detection-timeout=300"
+  # Important: keep these selectors in sync with the grep commands in the calc_run_flags job!
+  # This may be a lot better with maven 4, but with maven 3, excluding a project does not exclude its children, and it's not possible to include a project and explicitly exclude some children; compensate by doing excludes the low-tech way, at the shell level
+  JVM_TEST_INTEGRATION_TESTS_SELECTOR: "-f integration-tests -pl !gradle -pl !maven -pl !devmode -pl !devtools"
+  JVM_TEST_NORMAL_TESTS_SELECTOR: "-pl !docs -Dno-test-modules"
   PTS_MAVEN_ARGS: "-Ddevelocity.pts.enabled=${{ github.event_name == 'pull_request' && github.base_ref == 'main' && 'true' || 'false' }}"
   DB_USER: hibernate_orm_test
   DB_PASSWORD: hibernate_orm_test
@@ -336,7 +340,7 @@ jobs:
           echo "run_tcks=${run_tcks}" >> $GITHUB_OUTPUT
 
   jvm-tests:
-    name: JVM Tests - JDK ${{matrix.java.name}}
+    name: ${{ matrix.java.name }}
     runs-on: ${{ matrix.java.os-name }}
     needs: [build-jdk17, calculate-test-jobs]
     # Skip main in forks
@@ -352,8 +356,8 @@ jobs:
     steps:
       - name: Gradle Enterprise environment
         run: |
-          echo "GE_TAGS=jdk-${{matrix.java.name}}" >> "$GITHUB_ENV"
-          echo "GE_CUSTOM_VALUES=gh-job-name=JVM Tests - JDK ${{matrix.java.name}}" >> "$GITHUB_ENV"
+          echo "GE_TAGS=jdk-${{matrix.java.java-version}}" >> "$GITHUB_ENV"
+          echo "GE_CUSTOM_VALUES=gh-job-name=${{ matrix.java.name }}" >> "$GITHUB_ENV"
       - name: Stop mysql
         if: "!startsWith(matrix.java.os-name, 'windows') && !startsWith(matrix.java.os-name, 'macos')"
         run: |
@@ -419,23 +423,29 @@ jobs:
         if: github.event_name == 'pull_request'
         with:
           path: ~/.m2/.develocity/build-cache
-          key: develocity-cache-JVM Tests - JDK ${{matrix.java.name}}-${{ github.event.pull_request.number }}-${{ github.event.pull_request.head.sha }}
+          key: develocity-cache-${{matrix.java.name}}-${{ github.event.pull_request.number }}-${{ github.event.pull_request.head.sha }}
           restore-keys: |
-            develocity-cache-JVM Tests - JDK ${{matrix.java.name}}-${{ github.event.pull_request.number }}-
+            develocity-cache-${{matrix.java.name}}-${{ github.event.pull_request.number }}-
       - name: Setup Develocity Build Scan capture
         uses: gradle/develocity-actions/[email protected]
         with:
           capture-strategy: ON_DEMAND
-          job-name: "JVM Tests - JDK ${{matrix.java.name}}"
+          job-name: "${{ matrix.java.name }}"
           add-pr-comment: false
           add-job-summary: false
           develocity-access-key: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }}
           develocity-token-expiry: 6
       - name: Build
         env:
           CAPTURE_BUILD_SCAN: true
-        # Despite the pre-calculated run_jvm flag, GIB has to be re-run here to figure out the exact submodules to build.
-        run: ./mvnw $COMMON_MAVEN_ARGS $COMMON_TEST_MAVEN_ARGS $PTS_MAVEN_ARGS clean install -Dsurefire.timeout=1200 -pl !integration-tests/gradle -pl !integration-tests/maven -pl !integration-tests/devmode -pl !integration-tests/devtools -Dno-test-kubernetes -pl !docs ${{ matrix.java.maven_args }} ${{ needs.build-jdk17.outputs.gib_args }}
+        run: |
+          if [[ "${{ matrix.java.category }}" == *"Integration"* ]]; then
+            PL=$JVM_TEST_INTEGRATION_TESTS_SELECTOR
+          else
+            PL=$JVM_TEST_NORMAL_TESTS_SELECTOR
+          fi
+          # Despite the pre-calculated run_jvm flag, GIB has to be re-run here to figure out the exact submodules to build.
+          ./mvnw $COMMON_MAVEN_ARGS $COMMON_TEST_MAVEN_ARGS $PTS_MAVEN_ARGS $PL clean install -Dsurefire.timeout=1200  -Dno-test-kubernetes ${{ matrix.java.maven_args }} ${{ needs.build-jdk17.outputs.gib_args }}
       - name: Clean Gradle temp directory
         if: always()
         run: devtools/gradle/gradlew --stop && rm -rf devtools/gradle/gradle-extension-plugin/build/tmp
@@ -449,7 +459,7 @@ jobs:
         uses: actions/upload-artifact@v4
         if: failure()
         with:
-          name: test-reports-jvm${{matrix.java.name}}
+          name: test-reports-${{matrix.java.name}}
           path: 'test-reports.tgz'
           retention-days: 7
       - name: Prepare build reports archive
@@ -464,7 +474,7 @@ jobs:
         uses: actions/upload-artifact@v4
         if: always()
         with:
-          name: "build-reports-${{ github.run_attempt }}-JVM Tests - JDK ${{matrix.java.name}}"
+          name: "build-reports-${{ github.run_attempt }}-${{ matrix.java.name }}"
           path: |
             build-reports.zip
           retention-days: 7
@@ -474,15 +484,15 @@ jobs:
         # -- even in case of success, as some flaky tests won't fail the build
         if: always()
         with:
-          name: "debug-${{ github.run_attempt }}-JVM Tests - JDK ${{matrix.java.name}}"
+          name: "debug-${{ github.run_attempt }}-${{ matrix.java.name }}"
           path: "**/target/debug/**"
           if-no-files-found: ignore # If we're not currently debugging any test, it's fine.
           retention-days: 28 # We don't get notified for flaky tests, so let's give maintainers time to get back to it
       - name: Upload build.log (if build failed)
         uses: actions/upload-artifact@v4
         if: ${{ failure() || cancelled() }}
         with:
-          name: "build-logs-JVM Tests - JDK ${{matrix.java.name}}"
+          name: "build-logs-${{ matrix.java.name }}"
           path: |
             **/build.log
           retention-days: 7