Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid CI to have duplicate runs if changes are pushed in a row #2466

Merged
merged 3 commits into from
Dec 3, 2023

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Dec 3, 2023

Summary

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal requested review from zacwest and frenck December 3, 2023 17:11
@bgoncal bgoncal self-assigned this Dec 3, 2023
Comment on lines 19 to 21
concurrency:
group: ci-lint-${{ github.ref }}
cancel-in-progress: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be better to use a ci.yml-level concurrency value? (e.g. not in the individual jobs)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that but it was complaining that I needed to put under a job.
Before merging I'll try again, that would be better indeed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh weird, the docs really suggest you can do it globally in the file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found my mistake, I was placing under jobs, thats why the warning, now it should be good

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfa2289) 28.46% compared to head (75bcf90) 28.44%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2466      +/-   ##
==========================================
- Coverage   28.46%   28.44%   -0.02%     
==========================================
  Files         273      273              
  Lines       30259    30259              
==========================================
- Hits         8612     8606       -6     
- Misses      21647    21653       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgoncal bgoncal merged commit 8f7f0ec into master Dec 3, 2023
7 checks passed
@bgoncal bgoncal deleted the github-concurrency branch December 3, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants