Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drop support announcement view #2471

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Add drop support announcement view #2471

merged 6 commits into from
Dec 7, 2023

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Dec 5, 2023

Summary

Add drop support announcement view

Screenshots

Screenshot 2023-12-05 at 16 44 09

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal self-assigned this Dec 5, 2023
@bgoncal bgoncal requested a review from zacwest December 5, 2023 20:09
@bgoncal bgoncal marked this pull request as ready for review December 5, 2023 20:09
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 415 lines in your changes are missing coverage. Please review.

Comparison is base (8f7f0ec) 28.37% compared to head (88710bf) 28.14%.
Report is 4 commits behind head on master.

❗ Current head 88710bf differs from pull request most recent head 926eea1. Consider uploading reports for the commit 926eea1 to get more accurate results

Files Patch % Lines
...dentialsSharing/ThreadCredentialsSharingView.swift 0.00% 117 Missing ⚠️
Sources/App/WebView/WebViewController.swift 0.00% 90 Missing ⚠️
...DropSupport/DropSupportMessageViewController.swift 0.00% 86 Missing ⚠️
...alsSharing/ThreadCredentialsSharingViewModel.swift 38.46% 24 Missing ⚠️
...ces/App/Settings/DebugSettingsViewController.swift 0.00% 21 Missing ⚠️
...rces/Shared/DesignSystem/Components/CardView.swift 0.00% 21 Missing ⚠️
...rces/Shared/DesignSystem/Components/HAButton.swift 0.00% 14 Missing ⚠️
Sources/Shared/Environment/MatterWrapper.swift 0.00% 12 Missing ⚠️
...ntialsSharing/ThreadCredentialsSharing+build.swift 0.00% 8 Missing ⚠️
Sources/App/AppDelegate.swift 0.00% 6 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2471      +/-   ##
==========================================
- Coverage   28.37%   28.14%   -0.23%     
==========================================
  Files         273      285      +12     
  Lines       30284    30748     +464     
==========================================
+ Hits         8593     8655      +62     
- Misses      21691    22093     +402     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgoncal bgoncal merged commit 738c6ac into master Dec 7, 2023
4 checks passed
@bgoncal bgoncal deleted the drop-support-message branch December 7, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants