Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch unicode decode errors #4651

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Catch unicode decode errors #4651

merged 1 commit into from
Oct 26, 2023

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Oct 26, 2023

Proposed change

Yaml loader did not catch unicode decode errors as json loader did.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

Yaml loader did not catch unicode decode errors as json loader did.

Related to: home-assistant/core#102818
@pvizeli pvizeli merged commit 7361d39 into home-assistant:main Oct 26, 2023
22 of 23 checks passed
@elupus elupus deleted the patch-1 branch October 26, 2023 07:27
@pvizeli pvizeli added the bugfix A bug fix label Oct 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants