Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove folder only deletes from current filesystem #4653

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Oct 26, 2023

Proposed change

Fixes #4652 as supervisor will be blocked from removing anything from a mount during a restore if a mount somehow got left in one of the folders its trying to restore.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@mdegat01 mdegat01 merged commit b04efe4 into main Oct 26, 2023
23 checks passed
@mdegat01 mdegat01 deleted the handle-unmount-failed-restore branch October 26, 2023 20:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restoring a backup of Media folder while file is open leads to deleted files on network storage
2 participants