Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #60, Added syntactic content assistance to the filter field #110

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iamabhi747
Copy link

@iamabhi747 iamabhi747 commented Dec 7, 2024

Closes #60

This pull request introduces syntactic content assistance to the Filter component. The changes include the addition of a new Suggestion component, improved handling of filter input, and updates to the DSL parsing logic to support suggestions.

Enhancements to Filter Component:

  • Addition of Suggestion Component:
    • Imported and integrated Suggestion component to display suggestions based on user input. (frontend/components/Filter.svelte) [1] [2]
    • Introduced new state variables and handlers to manage suggestions visibility and interaction. (frontend/components/Filter.svelte) [1] [2]

Updates to DSL Parsing Logic:

  • Enhanced Token Labels and Parsing:
    • Updated token labels to be more descriptive and added a new PARTIAL token to support partial input suggestions. (frontend/dsl.ts) [1] [2] [3]
    • Modified parseDSL function to handle partial tokens and compute content assist suggestions. (frontend/dsl.ts) [1] [2]

These changes collectively enhance the user experience by providing real-time suggestions and improving the overall functionality of the filter input.

@iamabhi747
Copy link
Author

@glaslos @dkumiszhan please review this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add syntactic content assistance to the filter field
1 participant