browser: fix a few slips

hpi-swa-teaching · Jan 5, 2025 · 6e2c9fd · 6e2c9fd
1 parent 05d02ec
commit 6e2c9fd
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 12 deletions.
diff --git a/packages/SwaLintBrowser.package/SwaLintBrowser.class/instance/basicHelpForMessage..st b/packages/SwaLintBrowser.package/SwaLintBrowser.class/instance/basicHelpForMessage..st
@@ -1,14 +1,8 @@
 accessing - toolbuilder
 basicHelpForMessage: message
 
-	| selector iconHelp method |
-	Preferences balloonHelpInMessageLists ifFalse: [^ nil].
-
+	| selector method |
 	selector := (Symbol lookup: message) ifNil: [^ nil].
 	method := self selectedClassOrMetaClass compiledMethodAt: selector ifAbsent: [^ nil].
-	iconHelp := (self messageIconHelpFor: method selector) ifNotEmpty: [:t | 
-		t , Character cr, Character cr].
 
-	^ iconHelp asText
-		append: (self messageHelpForMethod: method);
-		yourself
+	^ self messageHelpForMethod: method
diff --git a/packages/SwaLintBrowser.package/SwaLintBrowser.class/instance/messageIconHelpFor..st b/packages/SwaLintBrowser.package/SwaLintBrowser.class/instance/messageIconHelpFor..st
@@ -0,0 +1,8 @@
+accessing - toolbuilder
+messageIconHelpFor: aSelector
+
+	self class showMessageIcons ifFalse: [^ String empty].
+
+	^ ToolIconHelp iconHelpNamed: (ToolIcons
+		iconForClass: self selectedClassOrMetaClass
+		selector: aSelector)
diff --git a/packages/SwaLintBrowser.package/SwaLintBrowser.class/instance/shiftedMessageListMenu..st b/packages/SwaLintBrowser.package/SwaLintBrowser.class/instance/shiftedMessageListMenu..st
@@ -18,7 +18,6 @@ shiftedMessageListMenu: aMenu
 		('inspect instances'						inspectInstances)
 		('inspect subinstances'					inspectSubInstances)).
 
-	self addExtraShiftedItemsTo: aMenu.
 	aMenu addList: #(
 		-
 		('change category...'					changeCategory)).

diff --git a/packages/SwaLintBrowser.package/SwaLintBrowser.class/methodProperties.json b/packages/SwaLintBrowser.package/SwaLintBrowser.class/methodProperties.json
@@ -11,7 +11,7 @@
 		"addModelItemsToWindowMenu:" : "ct 12/19/2024 23:25",
 		"aspectDependencies" : "ct 12/22/2024 01:49",
 		"authorFilterLabel" : "ct 12/10/2024 23:22",
-		"basicHelpForMessage:" : "ct 12/21/2024 21:20",
+		"basicHelpForMessage:" : "ct 1/5/2025 01:24",
 		"browseSelectedTestNode" : "ct 12/21/2024 20:39",
 		"browseSelectedTestNodeMapper" : "ct 12/21/2024 20:39",
 		"buildClassList:" : "ct 12/17/2024 22:15",
@@ -61,6 +61,7 @@
 		"labelForTestNodePath:" : "ct 12/18/2024 04:44",
 		"labelString" : "ct 12/10/2024 23:33",
 		"mainMessageListMenu:" : "ct 12/13/2024 00:37",
+		"messageIconHelpFor:" : "topa 3/1/2016 16:32",
 		"messageLabels" : "ct 12/18/2024 03:36",
 		"messageListMenu:shifted:" : "ct 12/17/2024 21:22",
 		"messageResultMenu:" : "ct 12/19/2024 21:29",
@@ -99,7 +100,7 @@
 		"settingsMenu:" : "ct 12/19/2024 23:25",
 		"shiftedClassListMenu:" : "ct 12/13/2024 00:38",
 		"shiftedClassListMenuMore:" : "ct 12/13/2024 00:38",
-		"shiftedMessageListMenu:" : "ct 12/13/2024 00:38",
+		"shiftedMessageListMenu:" : "ct 1/5/2025 01:26",
 		"shouldDisplayAllTests" : "ct 12/18/2024 03:07",
 		"shouldDisplayAllTests:" : "ct 12/18/2024 03:07",
 		"target" : "ct 12/12/2024 01:59",

diff --git a/packages/SwaLintBrowser.package/SwaLintBrowser.class/properties.json b/packages/SwaLintBrowser.package/SwaLintBrowser.class/properties.json
@@ -1,7 +1,7 @@
 {
 	"category" : "SwaLintBrowser-UI",
 	"classinstvars" : [
-		"redundantVar2" ],
+		 ],
 	"classtraitcomposition" : "SL2AspectDependencyGraph classTrait",
 	"classvars" : [
 		 ],