Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pbrh+ 28 add user to item waitlist #178

Merged
merged 32 commits into from
Dec 14, 2022
Merged

Feature/pbrh+ 28 add user to item waitlist #178

merged 32 commits into from
Dec 14, 2022

Conversation

julianaarnold
Copy link
Collaborator

@julianaarnold julianaarnold commented Dec 13, 2022 •
edited by AlexanderUngefug
Loading

PR checklist

  • dev-branch has been merged into local branch to resolve conflicts
  • tests and linter have passed AFTER local merge
  • localization is supported (Guide)
  • another dev reviewed and approved
  • Teams PO has approved (show via e.g. screenshots/screencapture/live demo)

MariusDoe and others added 28 commits December 2, 2022 20:08
@MariusDoe
Fix notifications sorting
516642d
@MariusDoe
Clean up notifications index page
409e8bd
@MariusDoe
Remove notification snippet from Notification
59b3016
@MariusDoe
Add LendRequestNotification
dcf4679
@MariusDoe
Make Notification actable
ae752f3
@MariusDoe
Let LendRequestNotification act_as a Notification
f015572
@MariusDoe
Add title and description to LendRequestNotification
b123d60
@MariusDoe
Add method delegation to specific Notification class
3c375ff
@MariusDoe
Show a notification's title and description
8bb97fd
@MariusDoe
Add ability to show a custom partial for notifications
7f228ea
@MariusDoe
Add dummy buttons for LendRequestNotification
3043103
@LinoH5
merged with feature/pbrh+-46-notification-event
d80864d
@LinoH5
starts implementing waitlist and adding users to it
9383e81
@LinoH5
implements leaving waitlist, notifications, status info, refactoring
cda5b8d
add tests for waitlist model
7888119
failing tests
f484754
tests and stuff
3b36248
@LinoH5
renames users in tests to clarify their role
3a14d78
@LinoH5
adds success status update for waitlist.add_user
b1f5a54
@AlexanderUngefug
rubocop automatic corrections
eaeede2
@LinoH5
removes waitlist button for owner, more tests, rubocop corrections
eac2d90
@LinoH5
merge with local changes
339f33b
@LinoH5
merged with dev
8219c88
@LinoH5
fixed failing tests
fc58161
@LinoH5
rubocop automatic corrections
292a95c
@LinoH5
rubocop fixes
a584763
@LinoH5
test fix
e5c645c
@LinoH5
Merge remote-tracking branch 'origin/dev' into feature/pbrh+-28-add-u…
453d781 
…ser-to-item-waitlist
@julianaarnold julianaarnold linked an issue Dec 13, 2022 that may be closed by this pull request
Add User to Waitlist of an Item #28
Closed
2 tasks
AlexanderUngefug
AlexanderUngefug approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@AlexanderUngefug AlexanderUngefug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkv29 tkv29 merged commit 0df3389 into dev Dec 14, 2022
@tkv29
Copy link
Collaborator

tkv29 commented Dec 14, 2022

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderUngefug AlexanderUngefug AlexanderUngefug approved these changes

@MariusDoe MariusDoe Awaiting requested review from MariusDoe

@jannikhuschka jannikhuschka Awaiting requested review from jannikhuschka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add User to Waitlist of an Item
5 participants
@julianaarnold @tkv29 @AlexanderUngefug @MariusDoe @LinoH5