Feature/br 37 create item UI #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add overall style, make buttons international, Uploaded images are not rendered immediately so far
antonneubauer
requested changes
Jan 4, 2023
Co-authored-by: antonneubauer <[email protected]>
Co-authored-by: antonneubauer <[email protected]>
saragrau
requested review from
lill28 and
antonneubauer
and removed request for
antonneubauer
lill28
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
All requests from @antonneubauer were implemented. Looks good to me.
antonneubauer
approved these changes
Jan 5, 2023
antonneubauer
added a commit
that referenced
this pull request
Jan 6, 2023
* add styling to new_item page add overall style, make buttons international, Uploaded images are not rendered immediately so far * Add missing fields to create item view * expand width of owner and holder in add and edit item view * Allow loading of item page after creation without an image * Allow dynamic display of images * changed styles accordingly to global styles sheet * Update app/views/items/new.html.erb Co-authored-by: antonneubauer <[email protected]> * Update app/views/items/new.html.erb Co-authored-by: antonneubauer <[email protected]> * implemented review suggestions Co-authored-by: Belana Zwadsich <[email protected]> Co-authored-by: Sara Grau <[email protected]> Co-authored-by: antonneubauer <[email protected]>
antonneubauer
added a commit
that referenced
this pull request
Jan 6, 2023
This reverts commit d408590.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37
We adapted the form of the new.html.erb page to the design guide. Now there is a placeholder when an image is uploaded and the uploaded image is also directly displayed.
PR checklist