Feature/mw 38 dashboard unread messages #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noel-Bastubbe
requested changes
Jan 5, 2023
| padding: 5px; | ||
| margin: 5px; | ||
| margin-bottom: 15px; | ||
| .subtitle { |
There was a problem hiding this comment.
Das sollte mit den neuen Stylesheets nicht mehr nötig sein, oder?
| font-size: 16px; | ||
| spacing: auto spacing; | ||
| margin-bottom: 18px; | ||
| <% if user_signed_in? && @user.notifications.where(unread: true).size > 0 %> |
There was a problem hiding this comment.
Der Check, ob der user signed in ist, sollte überflüssig sein, da nur auf das Dashboard zugegriffen werden kann, wenn man signed in ist.
There was a problem hiding this comment.
An der Stelle sind ohne zumindest immer Tests fehlgeschlagen, weil es user nicht kannte
|
|
||
| <h3 class="subtitle box"><%= t 'views.dashboard.unread_messages' %></h3> | ||
| <% if user_signed_in? %> |
There was a problem hiding this comment.
Hier ist der Check auch überflüssig, oder?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38
Button now displays "You have (number of unread notifications) unread messages" on dashboard. When there are more than zero of those, the button is highlighted in a darker blue. When new notifications are added while user is on the page, page needs to be refreshed.
PR checklist