Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ap 249 item list popularity #340

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Feature/ap 249 item list popularity #340

merged 3 commits into from
Jan 24, 2023

Conversation

CR1337
Copy link
Collaborator

@CR1337 CR1337 commented Jan 24, 2023 •
edited
Loading

Fixes #249

Item lists can now be sorted by popularity, ascending and descending. See Wiki.

PR checklist

  • dev-branch has been merged into local branch to resolve conflicts
  • tests and linter have passed AFTER local merge
  • localization is supported (Guide)
  • another dev reviewed and approved
  • if feature-Branch: Teams PO has approved (show via e.g. screenshots/screencapture/live demo)

@CR1337 CR1337 added the BP-AP BP Polze label Jan 24, 2023
@CR1337 CR1337 added this to the Statistics System milestone Jan 24, 2023
@CR1337 CR1337 self-assigned this Jan 24, 2023
LucasDerReisende
LucasDerReisende approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@LucasDerReisende LucasDerReisende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Lietze
Lietze approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@Lietze Lietze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, let's goooooo!

@CR1337 CR1337 merged commit 0335837 into dev Jan 24, 2023
@CR1337 CR1337 deleted the feature/ap-249-item-list-popularity branch January 24, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lietze Lietze Lietze approved these changes

@LucasDerReisende LucasDerReisende LucasDerReisende approved these changes

Assignees

@CR1337 CR1337

Labels
BP-AP BP Polze
Projects
None yet
Milestone
Statistics System
Development

Successfully merging this pull request may close these issues.

Popularity for list of items
3 participants
@CR1337 @LucasDerReisende @Lietze