Add links from navigation bar to sites (#5) #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Nils1729
commented
Nov 23, 2022
•
Nils1729
commented
- rebase when Create Item (should look like in figma) #37 is merged into dev (wrong issue, this branch is merged now)
1 task
dasGoogle
approved these changes
Nov 25, 2022
There was a problem hiding this comment.
Looks good to me. We will probably run into a merge conflict when merging with the language options, but this shouldn't be an issue.
Could you also open a follow-up issue or comment on the respective issue of the other teams so that we can add the link to the "New Item" page as soon as that is available?
Peek.2022-11-25.20-26.webm@benn02 For your review. |
|
The New Item Page was pushed to dev recently it is at /items/New so I would find it great if that link could also be added, but since it wasn't discussed when the sprint started I will approve it the way it is to not interfere with you while the sprint is ongoing |
benn02
approved these changes
Nov 25, 2022
Till-B
pushed a commit
that referenced
this pull request
Nov 29, 2022
* Add links from navigation bar to sites (#5) * Remove link to new_item_path as the page does not exist yet * Readd link to new item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.