Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seito: Add --vim-config #135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
*.cabal linguist-generated=true
/vim/test/assets/*.errors linguist-generated=true
25 changes: 22 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
runs-on: ${{ matrix.os }}

strategy:
fail-fast: true
matrix:
os:
- ubuntu-latest
Expand All @@ -29,7 +30,8 @@ jobs:
- os: macos-latest
ghc: '9.10'
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: hspec/setup-haskell@v1
with:
ghc-version: ${{ matrix.ghc }}
Expand Down Expand Up @@ -58,6 +60,23 @@ jobs:
env:
HSPEC_OPTIONS: --color

- run: vim/test/run.vim
if: runner.os == 'Linux'

- run: vim/test/assets/generate.sh
if: ${{ runner.os == 'Linux' && matrix.ghc != '9.4' }}

- run: git diff --exit-code

- shell: bash
run: |
untracked=$(git ls-files --others --exclude-standard)
if [ -n "$untracked" ]; then
echo "Untracked files:"
echo "$untracked"
exit 1
fi

success:
needs: build
runs-on: ubuntu-latest
Expand All @@ -67,6 +86,6 @@ jobs:
- run: false
if: needs.build.result != 'success'

- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Check for trailing whitespace
run: '! git grep -I "\s\+$"'
run: "! git grep -nI '[[:blank:]]$' -- . ':!vim/test/assets'"
18 changes: 14 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,14 @@ instead:

### Vim integration

You can use `sensei` to load the result of the last test run into your quickfix
You can use `seito` to load the results of the last test run into your quickfix
list by executing `:make` in Vim.

For this to work, you can either create a `Makefile` or set `makeprg` to a
custom value.
For this to work, you can choose one out of three options:

(In both cases, `sed` is used to strip ANSI color sequences.)
1. Create a `Makefile`
2. Set `makeprg` to a custom value
3. Use [`sensei.vim`](vim/sensei.vim)

#### Option 1: Create a `Makefile`

Expand All @@ -78,6 +79,15 @@ Add the following to your Vim configuration (e.g.
:set makeprg=seito
```

#### Option 3: Use `sensei.vim`:

Add the following to your Vim configuration (e.g.
`~/.vim/after/ftplugin/haskell.vim`):

```vim
execute 'source ' . system('seito --vim-config')
```

### Emacs integration

Similarly, you can use `sensei` to load the result of the last test run into an
Expand Down
4 changes: 3 additions & 1 deletion driver/seito.hs
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ import System.Environment
import Control.Monad
import qualified Data.ByteString.Lazy as L

import Paths_sensei (getDataFileName)

import Client

main :: IO ()
main = do
(success, output) <- getArgs >>= client ""
(success, output) <- getArgs >>= client getDataFileName ""
L.putStr output
unless success exitFailure
4 changes: 2 additions & 2 deletions package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ default-extensions:
- RecordWildCards
- ViewPatterns

other-extensions:
- NoFieldSelectors
data-files: vim/sensei.vim

dependencies:
- base >= 4.11 && < 5
Expand Down Expand Up @@ -64,6 +63,7 @@ executables:

seito:
source-dirs: driver
generated-other-modules: Paths_sensei
main: seito.hs

tests:
Expand Down
15 changes: 6 additions & 9 deletions sensei.cabal

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions solid.errors
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
src/Command.hs:200:22: error:
error: [GHC-21231]
lexical error in string/character literal at character 'c'

src/Command.hs:1:1: error:
`solid-pp' failed in phase `Haskell pre-processor'. (Exit code: 1)
5 changes: 3 additions & 2 deletions src/Client.hs
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@ import qualified Data.ByteString.Lazy as L

import HTTP (newSocket, socketName)

client :: FilePath -> [String] -> IO (Bool, L.ByteString)
client dir args = case args of
client :: (FilePath -> IO FilePath) -> FilePath -> [String] -> IO (Bool, L.ByteString)
client getDataFileName dir args = case args of
[] -> hIsTerminalDevice stdout >>= run
["--no-color"] -> run False
["--color"] -> run True
["--vim-config"] -> (,) True . fromString <$> getDataFileName "vim/sensei.vim"
_ -> do
hPutStrLn stderr $ "Usage: seito [ --color | --no-color ]"
return (False, "")
Expand Down
12 changes: 8 additions & 4 deletions test/ClientSpec.hs
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,21 @@ spec = do
describe "client" $ do
it "accepts --color" $ do
withSuccess $ \ dir -> do
client dir ["--color"] `shouldReturn` (True, fromString $ withColor Green "success")
client return dir ["--color"] `shouldReturn` (True, fromString $ withColor Green "success")

it "accepts --no-color" $ do
withSuccess $ \ dir -> do
client dir ["--no-color"] `shouldReturn` (True, "success")
client return dir ["--no-color"] `shouldReturn` (True, "success")

it "indicates failure" $ do
withFailure $ \ dir -> do
client dir ["--color"] `shouldReturn` (False, fromString $ withColor Red "failure")
client return dir ["--color"] `shouldReturn` (False, fromString $ withColor Red "failure")

context "when server socket is missing" $ do
it "reports error" $ do
withTempDirectory $ \ dir -> do
client dir [] `shouldReturn` (False, "could not connect to " <> fromString (socketName dir) <> "\n")
client return dir [] `shouldReturn` (False, "could not connect to " <> fromString (socketName dir) <> "\n")

context "with --vim-config" $ do
it "returns a path to a Vim support file" $ do
client return undefined ["--vim-config"] `shouldReturn` (True, "vim/sensei.vim")
Loading
Loading