CRT_degreeSign code shrink #1598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explorer09
commented
Feb 1, 2025
Make "CRT_degreeSign" a writable buffer that will be updated after the initDegreeSign() function. This avoids needing a static buffer in the function. Also use (MB_LEN_MAX + 1) for the buffer size, which is more appropriate than the magic number 4. One side effect of this change is that "CRT_degreeSign" will lose the const qualifier in the header (CRT.h). Signed-off-by: Kang-Che Sung <[email protected]>
Explorer09
force-pushed
the
init-degree-sign
branch
from
a0d8100 to
441b4fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
CRT_degreeSigna writable buffer that will be updated after theinitDegreeSign()function. This avoids needing a static buffer in the function.Also use
MB_LEN_MAXfor the buffer size, which is more appropriate than the magic number 4.One side effect of this change is that
CRT_degreeSignwill lose the const qualifier in the header (CRT.h).