Suppress package object inheritance warnings

http4s · Jan 28, 2024 · cc258cc · cc258cc
1 parent aee15dd
commit cc258cc
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 18 deletions.
diff --git a/build.sbt b/build.sbt
@@ -7,7 +7,7 @@ ThisBuild / developers := List(
   tlGitHubDev("ybasket", "Yannick Heiber"),
 )
 
-val Scala213 = "2.13.11"
+val Scala213 = "2.13.12"
 ThisBuild / crossScalaVersions := Seq("2.12.18", Scala213, "3.3.1")
 ThisBuild / scalaVersion := Scala213
 
@@ -17,14 +17,18 @@ ThisBuild / jsEnv := {
   new NodeJSEnv(NodeJSEnv.Config().withEnv(Map("TZ" -> "UTC")))
 }
 
+// ensure we don't fail compilation – package objects with inheritance are used in http4s/http4s as well,
+// better to stay style-consistent for now
+ThisBuild / scalacOptions += "-Wconf:msg=package object inheritance is deprecated:s"
+
 lazy val root = tlCrossRootProject.aggregate(xml, xmlScala, csv, cbor)
 
 val http4sVersion = "0.23.25"
 val scalaXmlVersion = "2.2.0"
 val fs2Version = "3.9.4"
 val fs2DataVersion = "1.10.0"
-val munitVersion = "1.0.0-M8"
-val munitCatsEffectVersion = "2.0.0-M3"
+val munitVersion = "1.0.0-M10"
+val munitCatsEffectVersion = "2.0.0-M4"
 
 lazy val xml = crossProject(JVMPlatform, JSPlatform, NativePlatform)
   .crossType(CrossType.Pure)

diff --git a/cbor/src/main/scala/org/http4s/fs2data/cbor/package.scala b/cbor/src/main/scala/org/http4s/fs2data/cbor/package.scala
@@ -16,6 +16,4 @@
 
 package org.http4s.fs2data
 
-import scala.annotation.nowarn
-
-package object cbor extends CborInstances @nowarn
+package object cbor extends CborInstances
diff --git a/csv/src/main/scala/org/http4s/fs2data/csv/package.scala b/csv/src/main/scala/org/http4s/fs2data/csv/package.scala
@@ -16,6 +16,4 @@
 
 package org.http4s.fs2data
 
-import scala.annotation.nowarn
-
-package object csv extends CsvInstances @nowarn
+package object csv extends CsvInstances
diff --git a/json/src/main/scala/org/http4s/fs2data/json/package.scala b/json/src/main/scala/org/http4s/fs2data/json/package.scala
@@ -16,7 +16,4 @@
 
 package org.http4s.fs2data
 
-import scala.annotation.nowarn
-
-@nowarn
 package object json extends JsonInstances
diff --git a/xml-scala/src/main/scala/org/http4s/fs2data/xml/scalaxml/package.scala b/xml-scala/src/main/scala/org/http4s/fs2data/xml/scalaxml/package.scala
@@ -16,6 +16,4 @@
 
 package org.http4s.fs2data.xml
 
-import scala.annotation.nowarn
-
-package object scalaxml extends ElemInstances @nowarn
+package object scalaxml extends ElemInstances
diff --git a/xml/src/main/scala/org/http4s/fs2data/xml/package.scala b/xml/src/main/scala/org/http4s/fs2data/xml/package.scala
@@ -16,6 +16,4 @@
 
 package org.http4s.fs2data
 
-import scala.annotation.nowarn
-
-package object xml extends XmlEventInstances @nowarn
+package object xml extends XmlEventInstances