improve: apply suggestion from codereview

We don't need new resource scope here. See https://github.com/typelevel/fs2/blob/fdc16e434b012a2be8b3a016d4fc2c72260d7cff/core/shared/src/main/scala/fs2/internal/Scope.scala#L34 about Scope.
http4s · Nov 13, 2024 · c1b9df0 · c1b9df0
1 parent fae648e
commit c1b9df0
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/core/src/main/scala/org/http4s/grpc/ServerGrpc.scala b/core/src/main/scala/org/http4s/grpc/ServerGrpc.scala
@@ -39,7 +39,7 @@ object ServerGrpc {
           .evalMap(f(_, req.headers))
           .flatMap(codecs.Messages.encodeSingle(encode)(_))
           .through(timeoutStream(_)(timeout.map(_.duration)))
-          .onFinalizeCase {
+          .onFinalizeCaseWeak {
             case Resource.ExitCase.Errored(_: TimeoutException) => status.complete((4, None)).void
             case Resource.ExitCase.Errored(e) => status.complete((2, e.toString().some)).void
             case Resource.ExitCase.Canceled => status.complete((1, None)).void
@@ -82,7 +82,7 @@ object ServerGrpc {
           .flatMap(f(_, req.headers))
           .through(codecs.Messages.encode(encode))
           .through(timeoutStream(_)(timeout.map(_.duration)))
-          .onFinalizeCase {
+          .onFinalizeCaseWeak {
             case Resource.ExitCase.Errored(_: TimeoutException) => status.complete((4, None)).void
             case Resource.ExitCase.Errored(e) => status.complete((2, e.toString().some)).void
             case Resource.ExitCase.Canceled => status.complete((1, None)).void
@@ -124,7 +124,7 @@ object ServerGrpc {
           .eval(f(codecs.Messages.decode(decode)(req.body), req.headers))
           .flatMap(codecs.Messages.encodeSingle(encode)(_))
           .through(timeoutStream(_)(timeout.map(_.duration)))
-          .onFinalizeCase {
+          .onFinalizeCaseWeak {
             case Resource.ExitCase.Errored(_: TimeoutException) => status.complete((4, None)).void
             case Resource.ExitCase.Errored(e) => status.complete((2, e.toString().some)).void
             case Resource.ExitCase.Canceled => status.complete((1, None)).void
@@ -166,7 +166,7 @@ object ServerGrpc {
         val body = f(codecs.Messages.decode(decode)(req.body), req.headers)
           .through(codecs.Messages.encode(encode))
           .through(timeoutStream(_)(timeout.map(_.duration)))
-          .onFinalizeCase {
+          .onFinalizeCaseWeak {
             case Resource.ExitCase.Errored(_: TimeoutException) => status.complete((4, None)).void
             case Resource.ExitCase.Errored(e) => status.complete((2, e.toString().some)).void
             case Resource.ExitCase.Canceled => status.complete((1, None)).void