Migrate to sbt-http4s-org plugin
#97
Conversation
danicheg
force-pushed
the
sbt-http4s-org
branch
from
ba3a406 to
6bb0ae0
Compare
danicheg
force-pushed
the
sbt-http4s-org
branch
from
d9fd490 to
977e0be
Compare
danicheg
force-pushed
the
sbt-http4s-org
branch
from
977e0be to
e53ca60
Compare
|
@armanbilge @valencik Sorry for that diff 🤷🏻 |
| // disable sbt-header plugin until we are not aligned on the license | ||
| ThisBuild / headerCheckAll := Nil |
build.sbt
Outdated
| @@ -1,13 +1,13 @@ | |||
| import explicitdeps.ExplicitDepsPlugin.autoImport.moduleFilterRemoveValue | |||
|
|
|||
| ThisBuild / tlBaseVersion := "0.0" // your current series x.y | |||
There was a problem hiding this comment.
I'm willing to set it to 0.1. Any objections?
There was a problem hiding this comment.
LGTM.
Confirmed scalafix/scalafmt setup are the same as http4s.
I noticed a couple things we could perhaps tidy up, but we could also do so in a followup PR to reduce noise here.
One thing we should do is add the commit where the scalafmt is first run to a .git-blame-ignore-revs file like Scala Steward does for us.
So a new .git-blame-ignore-revs file with the content:
# #97 Introduce sbt-http4s-org plugin
b92d1dbfcc29d3afcca0d2c143528f07b949dcd3
| for { | ||
| paramsAndUnparsed <- GeneratorParams.fromStringCollectUnrecognized(params) | ||
| params = paramsAndUnparsed._1 | ||
| unparsed = paramsAndUnparsed._2 | ||
| // unparsed = paramsAndUnparsed._2 |
There was a problem hiding this comment.
Should we just remove this if it's unused?
| val serviceCall = s"serviceImpl.${method.name}" | ||
| val eval = if (method.isServerStreaming) s"$Stream.eval(mkCtx(m))" else "mkCtx(m)" | ||
| // val serviceCall = s"serviceImpl.${method.name}" | ||
| // val eval = if (method.isServerStreaming) s"$Stream.eval(mkCtx(m))" else "mkCtx(m)" |
There was a problem hiding this comment.
Similarly. Or perhaps we want to leave that kind of tidying for another PR?
There was a problem hiding this comment.
I presumed there could be many other refactorings, so I just put this under comments.
|
Maybe Arman would have something to add. But we already have a quorum of approvers, so merging this. |
No description provided.