Handle http/2 request body without content-length

Http/2 is always streaming, so setting content-length is optional.
http4s · Dec 7, 2024 · 8637741 · 8637741
1 parent 3c8067a
commit 8637741
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/core/src/main/scala/org/http4s/jdkhttpclient/JdkHttpClient.scala b/core/src/main/scala/org/http4s/jdkhttpclient/JdkHttpClient.scala
@@ -63,10 +63,15 @@ object JdkHttpClient {
     def convertRequest(req: Request[F]): Resource[F, HttpRequest] =
       flow.toPublisher(req.body.chunks.map(_.toByteBuffer)).evalMap { publisher =>
         convertHttpVersionFromHttp4s[F](req.httpVersion).map { version =>
+          def isStreaming = version match {
+            case HttpClient.Version.HTTP_1_1 => req.isChunked
+            case HttpClient.Version.HTTP_2 => req.contentLength.isEmpty
+          }
+
           val rb = HttpRequest.newBuilder
             .method(
               req.method.name,
-              if (req.isChunked)
+              if (isStreaming)
                 BodyPublishers.fromPublisher(publisher)
               else
                 req.contentLength match {