Add list of child processes to running_procs #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fossam
requested changes
Sep 23, 2019
There was a problem hiding this comment.
thanks for the PR!
I like the idea as it could be useful - however on my test box with just ~660 processes:
/usr/bin/time /opt/osquery/osqueryi "<sql from the PR>" > /dev/null
52.65user 10.95system 1:07.02elapsed 94%CPU (0avgtext+0avgdata 15036maxresident)k
but same box, same amount of processes:
/usr/bin/time /opt/osquery/osqueryi "<original sql that we'd be replacing>" > /dev/null
0.95user 0.07system 0:01.04elapsed 98%CPU (0avgtext+0avgdata 13004maxresident)k
:(
we need to make it substantially faster. one minute is a bit long just to get child procs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.