PyO3: Add None and Tensor indexing to candle.Tensor
#1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright should be good to go, i added the list indexing and made sure that it works outside of the first tensor dimension. |
LaurentMazare
approved these changes
Oct 20, 2023
|
Thanks! |
EricLBuehler
pushed a commit
to EricLBuehler/candle
that referenced
this pull request
Oct 25, 2023
…e#1098) * Add proper `None` and `tensor` indexing * Allow indexing via lists + allow tensor/list indexing outside of first dimension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to expand tensor dimensions via a
Noneindex.e.g.:
Tensor indexing is also supported but similarly to
candle-coreits limited to 1D tensors.