PyO3: Add pytorch like .to() operator to candle.Tensor
#1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright, i changed it to allow a |
LaurentMazare
approved these changes
Oct 19, 2023
|
Thanks, agreed that the code doesn't look super nice with all this mutability, certainly feels error prone but let's start with this and clean this up later if it sticks. |
EricLBuehler
pushed a commit
to EricLBuehler/candle
that referenced
this pull request
Oct 25, 2023
…ce#1100) * add `.to()` operator * Only allow each value to be provided once via `args` or `kwargs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows casting or moving (or both at once) of a tensor via
.to(). I get why we don't want this on the rust side of things but for the wrapper it's just way more convenient as it's heavily used in existing pytorch models.