Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: negative axis #1296

Merged
merged 2 commits into from
Nov 8, 2023
Merged

fix: negative axis #1296

merged 2 commits into from
Nov 8, 2023

Conversation

YangNianYi
Copy link
Contributor

i think should be add with negative axis

@LaurentMazare
Copy link
Collaborator

Thanks for spotting this, actually we've recently introduced a normalize_axis function to avoid such possible issues by factoring this code out, I've tweaked your PR to actually use this function.

@LaurentMazare LaurentMazare merged commit 73d02f4 into huggingface:main Nov 8, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants