Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing tokenized_dataset to tokenized_datasets #703

Merged
merged 1 commit into from
May 17, 2024

Conversation

jpodivin
Copy link
Contributor

@jpodivin jpodivin commented May 5, 2024

The variable tokenized_dataset isn't initialized in the code. Leading to exception when the cell is reached. On the other hand tokenized_datasets var does exist. It was probably intended to be used in the first place.

Closes: #702

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@osanseviero osanseviero merged commit 93e49a8 into huggingface:main May 17, 2024
2 checks passed
@jpodivin jpodivin deleted the trainllmfromscratch/varfix branch May 20, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect variable name tokenized_dataset in Chapter 7 section 6 of course
3 participants