Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Nathan Habib <[email protected]>
Co-authored-by: Albert Villanova del Moral <[email protected]>
  • Loading branch information
3 people authored Dec 16, 2024
1 parent 431b4f2 commit fb4ecdc
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion src/lighteval/main_endpoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ def openai(
"""
from lighteval.logging.evaluation_tracker import EvaluationTracker

# from lighteval.models.model_input import GenerationParameters
from lighteval.models.endpoints.openai_model import OpenAIModelConfig
from lighteval.models.model_input import GenerationParameters
from lighteval.pipeline import EnvConfig, ParallelismManager, Pipeline, PipelineParameters
Expand Down
2 changes: 1 addition & 1 deletion src/lighteval/models/transformers/transformers_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def get_model_sha(self):
@dataclass
class BaseModelConfig(TransformersModelConfig):
def __post_init__(self):
super()
super().__post_init__()

logger.warning(
"Careful, BaseModelConfig is deprecated and will be removed, you should use TransformersModelConfig instead!"
Expand Down

0 comments on commit fb4ecdc

Please sign in to comment.