-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add adaptors to config and completion request #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll wait for your adaptor PR to be merged before this one and then update the API to camel case in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, I'd leave the codellama section regardless of adding ollama description, otherwise lgtm!
README.md
Outdated
#### [CodeLlama](https://huggingface.co/codellama/CodeLlama-13b-hf) | ||
|
||
```lua | ||
{ | ||
tokens_to_clear = { "<EOT>" }, | ||
fim = { | ||
enabled = true, | ||
prefix = "<PRE> ", | ||
middle = " <MID>", | ||
suffix = " <SUF>", | ||
}, | ||
model = "codellama/CodeLlama-13b-hf", | ||
context_window = 4096, | ||
tokenizer = { | ||
repository = "codellama/CodeLlama-13b-hf", | ||
} | ||
} | ||
``` | ||
|
||
> [!NOTE] | ||
> Spaces are important here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add that section back?
Closing in favor of #72 |
Implementation of adaptors for huggingface/llm-ls#40
Note that this doesn't include the required changes for
rename_all="camelCase"
, so it will not work until that effort is completed here.