Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add adaptors to config and completion request #68

Closed
wants to merge 3 commits into from

Conversation

noahbald
Copy link

@noahbald noahbald commented Dec 5, 2023

Implementation of adaptors for huggingface/llm-ls#40
Note that this doesn't include the required changes for rename_all="camelCase", so it will not work until that effort is completed here.

Copy link
Member

@McPatate McPatate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll wait for your adaptor PR to be merged before this one and then update the API to camel case in this PR.

README.md Show resolved Hide resolved
Copy link
Member

@McPatate McPatate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, I'd leave the codellama section regardless of adding ollama description, otherwise lgtm!

README.md Outdated
Comment on lines 82 to 102
#### [CodeLlama](https://huggingface.co/codellama/CodeLlama-13b-hf)

```lua
{
tokens_to_clear = { "<EOT>" },
fim = {
enabled = true,
prefix = "<PRE> ",
middle = " <MID>",
suffix = " <SUF>",
},
model = "codellama/CodeLlama-13b-hf",
context_window = 4096,
tokenizer = {
repository = "codellama/CodeLlama-13b-hf",
}
}
```

> [!NOTE]
> Spaces are important here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add that section back?

@McPatate
Copy link
Member

Closing in favor of #72

@McPatate McPatate closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants