add padding to input for mllama/paligemma/idefices2 #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wang, Yi A <[email protected]>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
kalyank007
approved these changes
Jan 7, 2025
shepark
reviewed
Jan 8, 2025
| @@ -211,7 +234,7 @@ def main(): | |||
| ] | |||
|
|
|||
| if model_type in ["llava", "idefics2", "llava_next", "mllama", "paligemma"]: | |||
| processor = AutoProcessor.from_pretrained(args.model_name_or_path) | |||
| processor = AutoProcessor.from_pretrained(args.model_name_or_path, padding_side="left") | |||
There was a problem hiding this comment.
Is this "padding_slide=left" common to the other "llava" and "llava_next" as well?
Title mentions only "mllama/paligemma/idefices2", but this option is set for all.
There was a problem hiding this comment.
yes. but we need #1674 this fix for llava/llava_next first
There was a problem hiding this comment.
and then, I will add llava/llava_next to https://github.com/huggingface/optimum-habana/blob/main/examples/image-to-text/run_pipeline.py#L324 as well
shepark
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (1699)
Before submitting