Noisy loss fix #293
Merged
Noisy loss fix #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng and noisy loss with TP>1."" This reverts commit 757886b.
|
Loss curves align with GPU for t5-small and TP=8. Additional tests for larger models are on its way.
|
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
bocchris-aws
changed the title
|
You need to reformat two of the files you modified. You can apply style changes automatically by typing |
michaelbenayoun
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the changes of the sampler from commit 757886b as it leads to loss curves that diverge from GPU baseline. Closes #253.