chore(ci): remove black from CI, we already use ruff #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
dacorvo
reviewed
Jan 29, 2025
| line-length = 119 | ||
| target-version = ['py38'] | ||
| extend-exclude = '.ipynb' | ||
|
|
There was a problem hiding this comment.
We need to find a way to keep the exclusion of the notebooks, as it is too painful.
There was a problem hiding this comment.
I force-pushed the last commit to do that and avoid changing the notebooks.
Now "make style" will reformat the code. I also applied the formatting to all files, so CI should not fail anymore due to code formatting.
tengomucho
force-pushed
the
remove-black
branch
from
c233b35 to
5da7fd7
Compare
dacorvo
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
CI was failing due to black errors, but we are already using ruff to check style and lint, so removing black seems like a fair choice.