Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zeropoint copy #106

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix zeropoint copy #106

merged 1 commit into from
Mar 5, 2024

Conversation

SunMarc
Copy link
Member

@SunMarc SunMarc commented Mar 4, 2024

What does this PR do ?

This PR fixes a typo when copying the zeropoint value in ops like .to(device). If a user moved the model after quantization, it could result in performance degradation.

cc @younesbelkada

@SunMarc SunMarc requested a review from dacorvo March 4, 2024 22:32
Copy link
Collaborator

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !

@dacorvo dacorvo merged commit 3bddd0a into huggingface:main Mar 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants