Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Deprecate Python3.7 and invalidate cache weekly #506

Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Mar 27, 2024

This PR is only a suggestion. Realized while working on #505 that SetFit is tested on Python3.7 which is deprecated since June 2023 and not supported anymore by transformers/huggingface_hub/datasets.

What this PR do:

  • do not test on Python3.7 anymore
  • test on Python3.11 instead. EDIT: test on Python 3.11 are failing due to "openvino==2022.3.0" being explicitly pinned so I remove support for 3.11. Might be worth checking this and adding it in a future PR.
  • update READMEs and adapt code to remove Python3.7 support
  • (unrelated) the test CI uses some cache to avoid redownloading all dependencies for each run. However it's usually good to invalidate this cache from time to time to avoid missing breaking changes from external dependencies. In this PR I suggest to invalidate the cache every week.

@@ -14,7 +13,7 @@
"datasets>=2.3.0",
"sentence-transformers>=2.2.1",
"evaluate>=0.3.0",
"huggingface_hub>=0.13.0",
"huggingface_hub>=0.22.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.13 is a quite old version. I'm not sure everything works correctly with it.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Wauplin Wauplin changed the title [CI] Deprecate Python3.7, test on Python 3.11, invalidate cache weekly [CI] Deprecate Python3.7 and invalidate cache weekly Mar 27, 2024
@Wauplin
Copy link
Contributor Author

Wauplin commented Mar 27, 2024

Looks like CI is failing with 3 different errors:

cc @tomaarsen I'm setting this PR as "ready for review". Please let me know if you have any comments.

@Wauplin Wauplin marked this pull request as ready for review March 27, 2024 10:44
@tomaarsen tomaarsen merged commit e78bfa1 into huggingface:main Sep 12, 2024
2 of 14 checks passed
@tomaarsen
Copy link
Member

Hello!

Apologies for the delay! I've merged these changes into main and resolved the remaining outstanding issues as well. I expect this'll all be included in a release quite soon (this week?). Thanks a bunch for making this PR!

  • Tom Aarsen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants