Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed evaluation_strategy to eval_strategy #538

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

sergiopaniego
Copy link
Contributor

Fixes #512 and #535

Following the deprecation of evaluation_strategy to eval_strategy: Hugging Face Transformers PR #30190.

Already covered in other repos:

@sergiopaniego
Copy link
Contributor Author

@tomaarsen 😄

@CalinLucian
Copy link

@tomaarsen

@tomaarsen tomaarsen merged commit 41297cf into huggingface:main Sep 12, 2024
0 of 18 checks passed
@sergiopaniego sergiopaniego deleted the update_eval_strategy branch September 12, 2024 08:30
@tomaarsen
Copy link
Member

Apologies for the delay! I've merged these changes into main and resolved the remaining outstanding issues as well. I expect this'll all be included in a release quite soon (this week?). Thanks a bunch for making this PR!

  • Tom Aarsen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment