Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed to work transformers after v4.45.2 #577

Merged
merged 5 commits into from
Jan 10, 2025

Conversation

DemirTonchev
Copy link
Contributor

Pull Request overview

fixes #564

Details

Fixed by setting:

tokenizer=self.processing_class,

here:

tokenizer=self.tokenizer,

and adding

    def log(self, logs: Dict[str, float], start_time: Optional[float] = None) -> None:
        logs = {f"{self.logs_prefix}_{k}" if k == "loss" else k: v for k, v in logs.items()}
        return super().log(logs)

here:

def log(self, logs: Dict[str, float]) -> None:

Copy link

@coolhannes coolhannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me but I've got no merging auth here

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DemirTonchev
Copy link
Contributor Author

@coolhannes can we merge this one? Who has rights? Can you tag them?

@tomaarsen
Copy link
Member

tomaarsen commented Jan 10, 2025

Big apologies for the delay from this. It's always a shame when SetFit doesn't work with the latest versions of transformers and Sentence Transformers anymore.

There should be 2 issues that remain that I can't resolve in setfit:

But that does mean that this should be good to go!

  • Tom Aarsen

@tomaarsen tomaarsen merged commit 8a792b1 into huggingface:main Jan 10, 2025
2 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants