Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

December 2024_xiangyu474_module1commit #158

Open
wants to merge 3 commits into
base: december-2024
Choose a base branch
from

Conversation

xiangyu474
Copy link

@xiangyu474 xiangyu474 commented Jan 2, 2025

December 2024 Student Submission

Module Completed

  • Module 1: Instruction Tuning
  • Module 2: Preference Alignment
  • Module 3: Parameter-efficient Fine-tuning
  • Module 4: Evaluation
  • Module 5: Vision-language Models
  • Module 6: Synthetic Datasets
  • Module 7: Inference
  • Module 8: Deployment

Changes Made

Describe what you've done in this PR:

  1. In 1_instruction_tuning\student_examples\xiangyu474\chat_templates_example.ipynb, I implemented 2 process_dataset functions.
  2. In 1_instruction_tuning\student_examples\xiangyu474\sft_finetuning_example.ipynb, I fine tuned the base model using "everyday-conversations" dataset.

Notebooks Added/Modified

List any notebooks you've added or modified:

  • Added new example in 1_instruction_tuning\student_examples\xiangyu474\chat_templates_example.ipynb
  • Added new example in 1_instruction_tuning\student_examples\xiangyu474\sft_finetuning_example.ipynb
  • Modified existing notebook with additional examples
  • Added documentation or comments

Checklist

  • I have read the module materials
  • My code runs without errors
  • I have pushed models and datasets to the huggingface hub
  • My PR is based on the december-2024 branch

Questions or Discussion Points

Add any questions you have or points you'd like to discuss:

  1. In sft_finetuning_example.ipynb, the training section was taking a long time. To address this, I modified the SFTConfig parameters, reducing max_steps from 1000 to 750. However, the resulting model output quality declined—it couldn't generate a proper haiku as requested.

Additional Notes

Any other information that might be helpful for reviewers:

@burtenshaw
Copy link
Collaborator

Nice work @xiangyu474 !

Would you like to take part in peer review? If so, mention me on a PR from another student, review it, and I'll get a student to review yours.

@nevernever69
Copy link

@burtenshaw this pr looks good read the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants