Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flash decoding kernel ROCm #2855

Merged
merged 7 commits into from
Jan 13, 2025
Merged

Add Flash decoding kernel ROCm #2855

merged 7 commits into from
Jan 13, 2025

Conversation

mht-sharma
Copy link
Collaborator

What does this PR do?

As per title!

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@mht-sharma mht-sharma requested a review from Narsil January 3, 2025 12:08
Copy link
Member

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but would be nice if we could get a CI run.

@mht-sharma
Copy link
Collaborator Author

Looks good to me, but would be nice if we could get a CI run.

@danieldk CI runners for rocm are currently deactivated due to security issues.

@danieldk danieldk merged commit 880ab9c into main Jan 13, 2025
13 of 14 checks passed
@danieldk danieldk deleted the flash_decoding_rocm branch January 13, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants