feat: Add gradient testing for Flash Attention 2 #35780
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds gradient testing for Flash Attention 2 (FA2) implementation.
The test ensures that gradients computed with FA2 match those computed with
the eager implementation within specified tolerance thresholds.
Key changes:
This addresses the TODO comment in test_modeling_common.py and improves
test coverage for FA2 implementation.