Code

Fix/best model checkpoint fix#35885

Code

Open

seanswyi wants to merge 11 commits intohuggingface:mainhuggingface/transformers:mainfrom seanswyi:fix/best-model-checkpoint-fixseanswyi/transformers:fix/best-model-checkpoint-fixCopy head branch name to clipboard

+229-9

Commits

Commits on Jan 28, 2025

• Set best_model_checkpoint only when ckpt exists.

  Show description for 26a6d06
  seanswyi

  committed
  26a6d06

  Copy full SHA for 26a6d06

• Added best_global_step to TrainerState.

  seanswyi

  committed
  01dbb77

  Copy full SHA for 01dbb77

• Added tests for best_model_checkpoint.

  seanswyi

  committed
  377b4c8

  Copy full SHA for 377b4c8

• Fixed hard-coded values in test to prevent fail.

  seanswyi

  committed
  61d2de7

  Copy full SHA for 61d2de7

• Added helper func and removed hard-coded best_step.

  seanswyi

  committed
  547dc88

  Copy full SHA for 547dc88

• Added side effect patch generator for _eval.

  seanswyi

  committed
  2f68664

  Copy full SHA for 2f68664

• Added evaluate side effect func.

  seanswyi

  committed
  f6248bb

  Copy full SHA for f6248bb

• Removed erroneous patching.

  seanswyi

  committed
  d5b70df

  Copy full SHA for d5b70df

• Fixed minor bug.

  seanswyi

  committed
  262f7f2

  Copy full SHA for 262f7f2

• Applied Ruff.

  seanswyi

  committed
  b8e9db4

  Copy full SHA for b8e9db4

• Fixed Ruff problem in make style.

  seanswyi

  committed
  492211b

  Copy full SHA for 492211b