Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mistral converter #35967

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update Mistral converter #35967

wants to merge 4 commits into from

Conversation

Cyrilvallez
Copy link
Member

What does this PR do?

As per the title. More general.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's re-use what's in pixtral conversion script

@@ -230,11 +220,114 @@ def convert_and_write_model(input_dir: str, output_dir: str, max_position_embedd
model.save_pretrained(output_dir)


def convert_and_write_tokenizer(input_dir: str, output_dir: str):
class MistralConverter:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it already exists for pixtral, worth adding to integrations/mistral.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants