Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Crystal 1.0 #19

Open
jwoertink opened this issue Apr 19, 2021 · 2 comments
Open

Support for Crystal 1.0 #19

jwoertink opened this issue Apr 19, 2021 · 2 comments

Comments

@jwoertink
Copy link

The version specified in the shard.yml will fallback to crystal (~> 0.35, >= 0.35.1) by default.

crystal: 0.35.1

For this to work with Crystal 1.0, it'll need to be changed to crystal: ">= 0.35.1"

@phil294
Copy link

phil294 commented Jul 12, 2022

while this makes sense, crystal never complained to me when I used this library in a 1.x project.

@jwoertink
Copy link
Author

We couldn't get specs to pass with it on Cable.cr without changing this. We ended up just removing this shard as a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants