Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert tox config to native TOML #235

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Convert tox config to native TOML #235

merged 1 commit into from
Oct 4, 2024

Conversation

hukkin
Copy link
Owner

@hukkin hukkin commented Oct 4, 2024

No description provided.

@hukkin hukkin merged commit 4be816b into master Oct 4, 2024
26 checks passed
@hukkin hukkin deleted the tox-native-toml branch October 4, 2024 08:49
@safiyat
Copy link

safiyat commented Nov 28, 2024

@hukkin The native toml module is not able to parse the updated pyproject.toml file, which prevents installation of setuptools-scm==v8.1.0.

Any way we can revert to the older spec of TOML, preserving the new information in the file?

@hukkin
Copy link
Owner Author

hukkin commented Nov 28, 2024

Can you give more details?

pip install 'setuptools-scm==v8.1.0'

works flawlessly on my machine.

The fix should probably be replacing the buggy parser rather than changing valid TOML, though.

@safiyat
Copy link

safiyat commented Nov 28, 2024

The command to install it from source is:

python -m pip install --no-binary :all: --only-binary :none: setuptools-scm==v8.1.0

This is reproducible using pip 21.1.3 and below only. We will try and fix this in our tooling instead of changing the toml file here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants