Develop #241
Merged
Develop #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bitbeckers
commented
Jan 3, 2025
bitbeckers
commented
- Fixes test suites
- Restores coverage tests
- Updates parsing of metadata.properties to be more flexibl
- Update Supabase version
- Set node version to 20 to be in syn with rest of stack
Fixes the mocked call by the RPC client to only use the MSW overrides instead of injecting vi spies with 0 response. This makes all current tests green 💚
Reduces the coverage threshold to pass the CI
The assertExists method failed as ENVIRONMENT was not set
adds local caching db url to gha ci
local db url in gha env declaraions
Restore unit test suites
Sets the node version to 20 to be in sync with rest of stack. Node 22 was used for integration tests which shouldn't dictate the runtime version. To fix some build warnings from supabase, updated the supabase version used in the GHA scripts and package.json
chore(deps): node 20 and supabase updates
Basic happy flow testing of URI event parsing (metadata/allowlist). Also tests for the successful parsing of a geoJSON attached to a metadata object
Parse URI event testing
When properties are attached to the metadata, first parse the object to make it suitable for storage
…arsing fix(storeMetadata): handling of properties field
The current parsing was to strict and rejected valid metadata sets. The schema was updated to allow any data and allow for a partial properties object since all fields are optional
Updated the URI event parser to log all issues on errors
…arsing Fix/metadata properties parsing
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.